Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyg-lib ToHeteroModule #5992

Merged
merged 144 commits into from
Jan 21, 2023
Merged

pyg-lib ToHeteroModule #5992

merged 144 commits into from
Jan 21, 2023

Conversation

puririshi98
Copy link
Contributor

@puririshi98 puririshi98 commented Nov 16, 2022

benchmark of new HeteroModule:
image
sufficient acceleration achieved
Remaining TODO for the next PR:

  • integrate into transformer setup

@github-actions github-actions bot added the nn label Nov 16, 2022
@puririshi98 puririshi98 changed the title Draft: To hetero pyg-lib Draft: to_hetero pyg-lib integration Nov 16, 2022
@puririshi98 puririshi98 self-assigned this Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #5992 (a18c401) into master (08ce552) will increase coverage by 0.05%.
The diff coverage is 98.59%.

❗ Current head a18c401 differs from pull request most recent head 8f35fa4. Consider uploading reports for the commit 8f35fa4 to get more accurate results

@@            Coverage Diff             @@
##           master    #5992      +/-   ##
==========================================
+ Coverage   85.57%   85.62%   +0.05%     
==========================================
  Files         404      405       +1     
  Lines       22312    22383      +71     
==========================================
+ Hits        19094    19166      +72     
+ Misses       3218     3217       -1     
Impacted Files Coverage Δ
torch_geometric/nn/to_hetero_module.py 98.59% <98.59%> (ø)
torch_geometric/nn/conv/hetero_conv.py 92.72% <0.00%> (+3.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@puririshi98 puririshi98 changed the title to_hetero pyg-lib integration pyg-lib ToHeteroModule Dec 8, 2022
@rusty1s
Copy link
Member

rusty1s commented Jan 21, 2023

@puririshi98 I moved Linear and MessagePassing to its own classes instead of merging them two one. Hope that works for you :)

@rusty1s rusty1s merged commit 041508d into master Jan 21, 2023
@rusty1s rusty1s deleted the to_hetero_pyglib branch January 21, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants