Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename drop_unconnected_nodes and drop_orig_edges arguments in AddMetapaths #5490

Merged
merged 6 commits into from
Sep 21, 2022

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Sep 21, 2022

No description provided.

@rusty1s
Copy link
Member Author

rusty1s commented Sep 21, 2022

@EdisonLeeeee Can you take a look?

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #5490 (0bdf4fe) into master (75c4806) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #5490      +/-   ##
==========================================
- Coverage   83.30%   83.30%   -0.01%     
==========================================
  Files         350      350              
  Lines       19045    19049       +4     
==========================================
+ Hits        15866    15868       +2     
- Misses       3179     3181       +2     
Impacted Files Coverage Δ
torch_geometric/transforms/add_metapaths.py 98.46% <83.33%> (-1.54%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@sachinsharma9780 sachinsharma9780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for adding the changes :)

@rusty1s rusty1s merged commit d3f35cb into master Sep 21, 2022
@rusty1s rusty1s deleted the rename_metapath branch September 21, 2022 10:51
@EdisonLeeeee
Copy link
Contributor

+1 looks good to me. Thanks for updating these!

JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
…ddMetapaths` (pyg-team#5490)

* update slack link

* update

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants