-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FeaturePropagation
as a transform
#5387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate you adding this. Please add a test for this feature. Left some initial comments, will take a look again in a few days.
Hi, the author of the paper here 👋 . Thanks a lot for working on this and let me know if you have any question! |
Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for adding this. left some final comments.
Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>
Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>
@wsad1 Thanks for your thorough reviews. Would it be able to merge now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Made some minor modifications.
Codecov Report
@@ Coverage Diff @@
## master #5387 +/- ##
==========================================
+ Coverage 83.37% 83.40% +0.03%
==========================================
Files 346 347 +1
Lines 18805 18842 +37
==========================================
+ Hits 15679 15716 +37
Misses 3126 3126
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This PR implements the
FeaturePropagation
method proposed in On the Unreasonable Effectiveness of Feature propagation in Learning on Graphs with Missing Node Features.Based on the prev discussion in this issue, I implement
FeaturePropagation
as atransform
.A minimal example to reproduce the experiments is also provided.