Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper error messages in __check_input__() #5042

Merged
merged 3 commits into from
Jul 24, 2022

Conversation

modanesh
Copy link
Contributor

Added proper and relative error messages while checking the edge_index in __check_input__() function.

@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #5042 (3653757) into master (6ed5caf) will decrease coverage by 1.90%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5042      +/-   ##
==========================================
- Coverage   84.74%   82.83%   -1.91%     
==========================================
  Files         331      331              
  Lines       18162    18158       -4     
==========================================
- Hits        15391    15041     -350     
- Misses       2771     3117     +346     
Impacted Files Coverage Δ
torch_geometric/nn/conv/message_passing.py 98.84% <100.00%> (ø)
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 14.51% <0.00%> (-53.00%) ⬇️
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/profile/profile.py 32.94% <0.00%> (-15.30%) ⬇️
torch_geometric/nn/inits.py 67.85% <0.00%> (-7.15%) ⬇️
torch_geometric/nn/resolver.py 88.00% <0.00%> (-6.00%) ⬇️
torch_geometric/transforms/add_self_loops.py 94.44% <0.00%> (-5.56%) ⬇️
torch_geometric/io/tu.py 93.90% <0.00%> (-2.44%) ⬇️
torch_geometric/transforms/virtual_node.py 97.56% <0.00%> (-2.44%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@rusty1s
Copy link
Member

rusty1s commented Jul 24, 2022

Thanks!

@rusty1s rusty1s enabled auto-merge (squash) July 24, 2022 06:22
@rusty1s
Copy link
Member

rusty1s commented Jul 24, 2022

Can we fix the linting error reported by the CI?

auto-merge was automatically disabled July 24, 2022 06:35

Head branch was pushed to by a user without write access

@rusty1s rusty1s merged commit 575611f into pyg-team:master Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants