Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix norm in examples and dmon_pool #4959

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Fix norm in examples and dmon_pool #4959

merged 4 commits into from
Jul 12, 2022

Conversation

lightaime
Copy link
Contributor

This PR fixed the deprecated batch_norm to norm in examples and dmon_pool.

@lightaime lightaime requested a review from rusty1s July 11, 2022 15:44
@lightaime lightaime changed the title Fix norm in examples and dmon_pool Fix norm in examples and dmon_pool Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #4959 (12c2b62) into master (bac7021) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 12c2b62 differs from pull request most recent head 1de2669. Consider uploading reports for the commit 1de2669 to get more accurate results

@@            Coverage Diff             @@
##           master    #4959      +/-   ##
==========================================
- Coverage   82.72%   82.70%   -0.02%     
==========================================
  Files         330      330              
  Lines       17905    17905              
==========================================
- Hits        14812    14809       -3     
- Misses       3093     3096       +3     
Impacted Files Coverage Δ
torch_geometric/nn/dense/dmon_pool.py 98.00% <100.00%> (ø)
torch_geometric/nn/models/mlp.py 94.44% <0.00%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac7021...1de2669. Read the comment docs.

@rusty1s rusty1s merged commit a8601aa into master Jul 12, 2022
@rusty1s rusty1s deleted the mlp_norm_examples branch July 12, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants