Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: NeighborLoader test with Tuple[FeatureStore, GraphStore] #4851

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

mananshah99
Copy link
Contributor

The previous test was not correctly re-initializing the feature store and graph store in each itertools.product(...) step.

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #4851 (be4f37c) into master (7ea71e3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4851   +/-   ##
=======================================
  Coverage   82.78%   82.78%           
=======================================
  Files         326      326           
  Lines       17635    17635           
=======================================
  Hits        14600    14600           
  Misses       3035     3035           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea71e3...be4f37c. Read the comment docs.

@mananshah99 mananshah99 merged commit ded9a7b into master Jun 23, 2022
@mananshah99 mananshah99 deleted the fix_nl_test branch June 23, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants