Separate Key into Character and NamedKey
#50
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes `Period` docs having invalid HTML, and allows us to more easily parse more stuff in the future.
This makes most of the key Copy, and allows other crates like Winit to more easily use their own string types.
|
Please rebase the PR. I wonder if it is possible to have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes most of the key
Copy, and allows other crates like Winit to more easily use their own string types.Part of #19.
See also rust-windowing/winit#2995 and rust-windowing/winit#3143 for discussion on a similar change in Winit.
WIP!