Return control to pyenv-uninstall in uninstall/envs.bash #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix #320, since returning control to
pyenv-uninstall
would allow the rest of thebefore_uninstall
andafter_install
hooks to run.From my understanding, the
exec
would pass control to the other script and never return it, so it would never hit theexit
.. and if it did, there's no real need to since they are in mutually exclusiveif
statements. However, I might be misunderstanding something here, or there might have been a reason it was done like that, so it's quite possible there's a problem with this solution that I'm not aware of.One problem I noticed was the error when returning control to
pyenv-uninstall
. SettingFORCE=t
avoids this error, although I'm not sure what exactly that does so I'm not sure if there's any issues with that.