Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return control to pyenv-uninstall in uninstall/envs.bash #321

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

aiguofer
Copy link
Contributor

@aiguofer aiguofer commented Jul 21, 2019

This would fix #320, since returning control to pyenv-uninstall would allow the rest of the before_uninstall and after_install hooks to run.

From my understanding, the exec would pass control to the other script and never return it, so it would never hit the exit.. and if it did, there's no real need to since they are in mutually exclusive if statements. However, I might be misunderstanding something here, or there might have been a reason it was done like that, so it's quite possible there's a problem with this solution that I'm not aware of.

One problem I noticed was the error when returning control to pyenv-uninstall. Setting FORCE=t avoids this error, although I'm not sure what exactly that does so I'm not sure if there's any issues with that.

# Conflicts:
#	etc/pyenv.d/uninstall/envs.bash
@native-api native-api merged commit 633711a into pyenv:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyenv-virtualenv breaks after_uninstall hooks
2 participants