WORKAROUND: Force usage of pythonX.X for -m venv #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses ${PYENV_VERSION:0:3} to force venv to correctly
make all of the necessary symlinks in the virtualenv's
bin directory.
While the first commit seemingly produced the intended results, the changes inadvertantly and unexpected broke all of the unit tests. This commit represnts changes to both pyenv-virtualenv and its associated tests to employ the force pythonX.X workaround.
|
+1 This is a genuine issue for tox users. |
|
This would break for non-CPython; already fixed in #296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses ${PYENV_VERSION:0:3} to force venv to correctly
make all of the necessary symlinks in the virtualenv's
bin directory.
Refer to issue #206 for details.