Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added files needed to run tests on appveyor. #315

Merged
merged 2 commits into from
Dec 29, 2015
Merged

Added files needed to run tests on appveyor. #315

merged 2 commits into from
Dec 29, 2015

Conversation

moorepants
Copy link
Member

Addresses #303.

  • There are no merge conflicts.
  • If there is a related issue, a reference to that issue is in the
    commit message.
  • Unit tests have been added for the new feature.
  • The PR passes tests both locally (run nosetests) and on Travis CI.
  • All public methods and classes have docstrings. (We use the numpydoc
    format    .)
  • An explanation has been added to the online documentation. (docs
    directory)
  • The code follows PEP8 guidelines. (use a linter, e.g.
    pylint, to check your code)
  • The new feature is documented in the Release
    Notes    .
  • The code is backwards compatible. (All public methods/classes must
    follow deprecation cycles.)
  • All reviewer comments have been addressed.
  • Merge Modified Cython setup.py template for Windows. #313 and update this branch wrt to master.
  • Figure out why the temp files from Cython are not accessible.
  • Skip Theano tests.
  • Figure out why compilation fails with Python 3.4

@moorepants
Copy link
Member Author

This is the Python 3.4 compilation error:

[1/1] Cythonizing pydy_codegen_0.pyx
running build_ext
building 'pydy_codegen_0' extension
creating build
creating build\temp.win-amd64-3.5
creating build\temp.win-amd64-3.5\Release
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\Bin\amd64\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MT -IC:\Python34_64\lib\site-packages\numpy\core\include -IC:\Python34_64\include -IC:\Python34_64\include "-Ic:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE" "-IC:\Program Files\Microsoft SDKs\Windows\v7.1\INCLUDE" "-IC:\Program Files\Microsoft SDKs\Windows\v7.1\INCLUDE\gl" /Tcpydy_codegen_0.c /Fobuild\temp.win-amd64-3.5\Release\pydy_codegen_0.obj
pydy_codegen_0.c
c:\python34_64\lib\site-packages\numpy\core\include\numpy\npy_1_7_deprecated_api.h(12) : Warning Msg: Using deprecated NumPy API, disable it by #defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION 
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\Bin\amd64\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MT -IC:\Python34_64\lib\site-packages\numpy\core\include -IC:\Python34_64\include -IC:\Python34_64\include "-Ic:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE" "-IC:\Program Files\Microsoft SDKs\Windows\v7.1\INCLUDE" "-IC:\Program Files\Microsoft SDKs\Windows\v7.1\INCLUDE\gl" /Tcpydy_codegen_0_c.c /Fobuild\temp.win-amd64-3.5\Release\pydy_codegen_0_c.obj
pydy_codegen_0_c.c
creating C:\Users\appveyor\AppData\Local\Temp\1\tmphl0sjk_x.pydy_compile\build\lib.win-amd64-3.5
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\Bin\amd64\link.exe /nologo /INCREMENTAL:NO /LTCG /nodefaultlib:libucrt.lib ucrt.lib /DLL /MANIFEST:EMBED,ID=2 /MANIFESTUAC:NO /LIBPATH:C:\Python34_64\libs /LIBPATH:C:\Python34_64\PCbuild\amd64 "/LIBPATH:c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\Lib\amd64" "/LIBPATH:C:\Program Files\Microsoft SDKs\Windows\v7.1\Lib\X64" /EXPORT:PyInit_pydy_codegen_0 build\temp.win-amd64-3.5\Release\pydy_codegen_0.obj build\temp.win-amd64-3.5\Release\pydy_codegen_0_c.obj /OUT:build\lib.win-amd64-3.5\pydy_codegen_0.cp35-win_amd64.pyd /IMPLIB:build\temp.win-amd64-3.5\Release\pydy_codegen_0.cp35-win_amd64.lib
LINK : fatal error LNK1117: syntax error in option 'MANIFEST:EMBED,ID=2'
error: command 'c:\\Program Files (x86)\\Microsoft Visual Studio 10.0\\VC\\Bin\\amd64\\link.exe' failed with exit status 1117

@moorepants
Copy link
Member Author

Here are some findings:

The appveyor Python demo had a similar failure at some point:
https://ci.appveyor.com/project/ogrisel/python-appveyor-demo/build/1.0.152

Same error and conclusion that the correct compiler was not installed:
https://groups.google.com/a/continuum.io/forum/#!msg/anaconda/cTz7cVPQkKM/-XlEAFIuAgAJ

Build is incorrectly using the 2008 compiler:
https://social.msdn.microsoft.com/Forums/vstudio/en-US/966cf58b-ee8b-4333-810d-dd81ff7f0b3d/getting-manifest-error-in-dll-project-upgraded-to-vs2012-from-vs2008?forum=vcgeneral

astropy/photutils same error:
https://ci.appveyor.com/project/Astropy/photutils/build/1.0.154/job/vt999t9pemy8dcqq
astropy/photutils#294

@moorepants moorepants mentioned this pull request Dec 27, 2015
Closed
@moorepants
Copy link
Member Author

@chrisdembia Do you have any idea about this? I know you've worked with appveyor more.

@moorepants
Copy link
Member Author

The compilation was failing due to a mismatch in the installed miniconda python version (i.e. Miniconda35 was being downloaded when I thought it was Miniconda3.4).

@moorepants
Copy link
Member Author

@pydy/pydy-developers Ok, this is finally working on appveyor for Python 2.7, 3.4, and 3.5. Needs review.

@moorepants
Introduces Windows CI testing on Appveyor.
718d651 
- Added appveyor config files base on these two projects:
  - https://github.com/rmcgibbo/python-appveyor-conda-example
  - https://github.com/ogrisel/python-appveyor-demo
- Cython and Theano based tests are now skipped if the packages aren't
  available. (We do not test Theano on Windows currently.)
- Circumvent the Windows rmtree permissions issue. (rmtree doesn't work on
  Windows)
- Enabled a verbose option for the Cython compliation.
@moorepants
Copy link
Member Author

@pydy/pydy-developers I squashed commits here and this is ready for review.

@moorepants
Copy link
Member Author

@yashu-seth Would you like to review this PR? If so, please look through the list at the top of the PR and confirm that I've covered the relevant points.

@yashu-seth
Copy link
Contributor

@moorepants okay let me see this.

@chrisdembia
Copy link
Contributor

Appveyor badge doesn't show?
image

@moorepants
Copy link
Member Author

I think it will show once the appveyor.yml file is in the master branch.

@yashu-seth
Copy link
Contributor

@moorepants I think everything has been covered.

@moorepants
Copy link
Member Author

@chrisdembia I'm going to merge based on @yashu-seth's review unless you have further comments. I'll fix the appveyor badge if it doesn't show up after merging.

@chrisdembia
Copy link
Contributor

Sounds good.

moorepants added a commit that referenced this pull request Dec 29, 2015
@moorepants
Merge pull request #315 from moorepants/appveyor
26699c4 
Added files needed to run tests on appveyor.
@moorepants moorepants merged commit 26699c4 into pydy:master Dec 29, 2015
@moorepants moorepants mentioned this pull request Dec 29, 2015
Closed
@moorepants moorepants deleted the appveyor branch January 6, 2016 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moorepants @yashu-seth @chrisdembia