Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare Dataset, DataArray, Variable, GroupBy unhashable #8392

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Declare Dataset, DataArray, Variable, GroupBy unhashable #8392

merged 3 commits into from
Nov 9, 2023

Commits on Nov 9, 2023

  1. Add unhashable to generate_ops

    @maresb
    maresb committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    a468d08 View commit details
    Browse the repository at this point in the history

  2. Regenerate _typed_ops after adding "unhashable"

    @maresb
    maresb committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    0474be9 View commit details
    Browse the repository at this point in the history

  3. Fix variable redefinition 

    The previous commit revealed the following mypy error:

xarray/core/dataset.py: note: In member "swap_dims" of class "Dataset":
xarray/core/dataset.py:4415: error: Incompatible types in assignment (expression has type "Variable", variable has type "Hashable")  [assignment]
xarray/core/dataset.py:4415: note: Following member(s) of "Variable" have conflicts:
xarray/core/dataset.py:4415: note:     __hash__: expected "Callable[[], int]", got "None"
xarray/core/dataset.py:4416: error: "Hashable" has no attribute "dims"  [attr-defined]
xarray/core/dataset.py:4419: error: "Hashable" has no attribute "to_index_variable"  [attr-defined]
xarray/core/dataset.py:4430: error: "Hashable" has no attribute "to_base_variable"  [attr-defined]
    @maresb
    maresb committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    f28b735 View commit details
    Browse the repository at this point in the history