Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip-ci] Add compute to groupby benchmarks #7690

Merged
merged 2 commits into from
Mar 29, 2023
Merged

[skip-ci] Add compute to groupby benchmarks #7690

merged 2 commits into from
Mar 29, 2023

Conversation

dcherian
Copy link
Contributor

oops!

@dcherian dcherian added the run-benchmark Run the ASV benchmark workflow label Mar 28, 2023
@dcherian dcherian requested a review from Illviljan March 28, 2023 03:19
@Illviljan
Copy link
Contributor

How come the benchmarks is not failing? Shouldn't it be significantly slower now?

@dcherian dcherian merged commit 4fc8445 into pydata:main Mar 29, 2023
@dcherian
Copy link
Contributor Author

it runs the new benchmark on both main and HEAD so it should work as long as there is no error in the benchmarks

@dcherian dcherian deleted the groupby-bench branch March 29, 2023 15:21
dcherian added a commit to kmsquire/xarray that referenced this pull request Mar 29, 2023
@dcherian
Merge remote-tracking branch 'upstream/main' into feature/rolling-pad
d02d2fd 
* upstream/main:
  Save groupby codes after factorizing, pass to flox (pydata#7206)
  [skip-ci] Add compute to groupby benchmarks (pydata#7690)
  Delete built-in cfgrib backend (pydata#7670)
  Added a pronunciation guide to the word Xarray in the README.MD fil… (pydata#7677)
  boundarynorm fix (pydata#7553)
  Fix lazy negative slice rewriting. (pydata#7586)
  [pre-commit.ci] pre-commit autoupdate (pydata#7687)
  Adjust sidebar font colors (pydata#7674)
  Bump pypa/gh-action-pypi-publish from 1.8.1 to 1.8.3 (pydata#7682)
  Raise PermissionError when insufficient permissions (pydata#7629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Illviljan Illviljan Awaiting requested review from Illviljan

Assignees
No one assigned
Labels
run-benchmark Run the ASV benchmark workflow topic-performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcherian @Illviljan