Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Array API changes #7067

Merged
merged 8 commits into from
Oct 18, 2022
Merged

More Array API changes #7067

merged 8 commits into from
Oct 18, 2022

Conversation

tomwhite
Copy link
Contributor

@tomwhite tomwhite commented Sep 22, 2022

Including aggregation with nans, astype, where, stack.

This is a follow-on to #6804, delegating more functions to np or xp as appropriate.

  • Tests added

@github-actions github-actions bot added topic-arrays related to flexible array support topic-CF conventions labels Sep 22, 2022
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks the continued work on this, @tomwhite

xarray/core/variable.py Outdated Show resolved Hide resolved
xarray/core/nanops.py Outdated Show resolved Hide resolved
xarray/core/duck_array_ops.py Outdated Show resolved Hide resolved
@tomwhite
Copy link
Contributor Author

This is great feedback - thanks @keewis! I will take a look at implementing your suggestions.

@tomwhite
Copy link
Contributor Author

Updated with all the suggestions. How does this look now?

Copy link
Member

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me like all the comments have been addressed, nice!

@dcherian
Copy link
Contributor

image

Looks like we're good to go here with respect to pint. Thanks @tomwhite !

@dcherian dcherian added the plan to merge Final call for comments label Oct 17, 2022
@dcherian dcherian enabled auto-merge (squash) October 18, 2022 16:40
@dcherian dcherian merged commit 7f1f911 into pydata:main Oct 18, 2022
keewis pushed a commit to keewis/xarray that referenced this pull request Oct 19, 2022
* More Array API changes, including aggregation with nans, astype, where, stack.

* Add `reshape` to `duck_array_ops`

* Simplify `as_shared_dtype`

* Add `sum_where` to `duck_array_ops`

* Remove unused `_replace_nan` function

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update xarray/core/duck_array_ops.py

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments topic-arrays related to flexible array support topic-CF conventions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants