Review (re)set_index #6992
Merged
Review (re)set_index #6992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore old behavior, i.e., - drop the multi-index dimension name (even if drop=False) unless reset_index still returns a multi-index - rename the level coordinate to the dimension name if the multi-index is reduced to a single index - drop the whole multi-index if its dimension coordinate is given as argument Fix IndexVariable -> Variable conversion
- Convert the coordinates left unindexed from IndexVariable to Variable - Keep multi-index coordinates next to each other in a consistent order
This was referenced Sep 8, 2022
Closed
|
Let's merge this. The failing flaky tests are not related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_coord_namesthan_variableson Dataset #7036whats-new.rstRestore behavior prior to the explicit indexes refactor (i.e., refactored but without breaking changes).
TODO:
set_indexreset_indexFor
reset_index, the only behavior that is not restored here is the coordinate renamed with a_suffix when dropping a single index. This was originally to prevent any coordinate with no index matching a dimension name, which is now irrelevant. That is a quite dirty workaround and I don't know who is relying on it (no complaints yet), but I'm open to restore it if needed (esp. considering that we may later deprecatereset_indexcompletely in favor ofdrop_indexes#6971).