Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum version requirements for dask from 2.15 to 2.24 #5726

Merged
merged 5 commits into from
Aug 25, 2021

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Aug 21, 2021

Dask released 2.24 around august 22 2020: https://github.com/dask/dask/releases/tag/2.24.0

@Illviljan Illviljan changed the title Bump min requirements for dask Bump min requirements for dask to 2.24 Aug 21, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2021

Unit Test Results

         6 files  ±0           6 suites  ±0   49m 30s ⏱️ ±0s
16 225 tests ±0  14 489 ✔️ ±0  1 736 💤 ±0  0 ❌ ±0 
90 546 runs  ±0  82 363 ✔️ ±0  8 183 💤 ±0  0 ❌ ±0 

Results for commit 4fd81b5. ± Comparison against base commit 4fd81b5.

♻️ This comment has been updated with latest results.

@Illviljan Illviljan changed the title Bump min requirements for dask to 2.24 Bump minimum version requirements for dask from 2.15 to 2.24 Aug 21, 2021
@max-sixty
Copy link
Collaborator

This looks good!

@keewis is this compatible / duplicative with your min versions check script?

@keewis
Copy link
Collaborator

keewis commented Aug 21, 2021

No, but it will be in 2-3 days (we're using the dates on conda-forge instead of the official release dates):

 dask              2.24    (2020-08-24) 2.23    (2020-08-14) > (!)
 distributed       2.24    (2020-08-22) 2.23    (2020-08-14) > (!)

I guess we should probably wait with the merge until then to avoid causing the CI to break. Then again, other CI are already failing so it might not make a difference.

@Illviljan
Copy link
Contributor Author

Yeah, a little unfortunate that dask had a later date on conda-forge. But I wasn't expecting an immediate merge anyway.

@Illviljan Illviljan closed this Aug 25, 2021
@Illviljan Illviljan reopened this Aug 25, 2021
@Illviljan
Copy link
Contributor Author

The minimum version check now passes for both dask and distributed. This is ready for review/merge now.

Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Illviljan

@dcherian dcherian added the plan to merge Final call for comments label Aug 25, 2021
@keewis
Copy link
Collaborator

keewis commented Aug 25, 2021

thanks, @Illviljan

@keewis keewis merged commit 4fd81b5 into pydata:main Aug 25, 2021
@Illviljan Illviljan deleted the bump_dask_min_reqs branch September 8, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants