Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast PandasIndex to pd.(Multi)Index #5385

Merged
merged 3 commits into from
May 28, 2021
Merged

Cast PandasIndex to pd.(Multi)Index #5385

merged 3 commits into from
May 28, 2021

Conversation

benbovy
Copy link
Member

@benbovy benbovy commented May 27, 2021 •
edited
Loading

@benbovy
fastpath cast Xarray's PandasIndex to pd.Index
feb1077 
Also make sure that a multi-index with one unique level are not cast to
a simple pd.Index
@benbovy
update tests
6c31147
@benbovy benbovy mentioned this pull request May 27, 2021
Closed
max-sixty
max-sixty approved these changes May 27, 2021
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@benbovy benbovy merged commit 2b38adc into pydata:master May 28, 2021
TomNicholas pushed a commit to TomNicholas/xarray that referenced this pull request May 28, 2021
@benbovy @TomNicholas
Cast PandasIndex to pd.(Multi)Index (pydata#5385)
95ebf95 
* fastpath cast Xarray's PandasIndex to pd.Index

Also make sure that a multi-index with one unique level are not cast to
a simple pd.Index

* update tests

* [skip-ci] update what's new
@benbovy benbovy deleted the fix-regression-mindex-cast branch March 29, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: "ValueError: cannot unstack dimensions that do not have a MultiIndex" when unstacking a MultiIndex
2 participants
@benbovy @max-sixty