Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the build wheel test #5270

Merged
merged 1 commit into from
May 6, 2021
Merged

fix the build wheel test #5270

merged 1 commit into from
May 6, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented May 6, 2021

uploading to TestPyPI works now, but the check afterwards still fails, which I think is because we use --index-url instead of --extra-index-url

  • Passes pre-commit run --all-files

@keewis keewis merged commit 054f81a into pydata:master May 6, 2021
@keewis keewis deleted the fix-pypi branch May 6, 2021 16:10
@@ -76,7 +76,7 @@ jobs:
run: |
sleep 3
python -m pip install --upgrade pip
python -m pip install --index-url https://test.pypi.org/simple --upgrade xarray
python -m pip install --extra-index-url https://test.pypi.org/simple --upgrade xarray
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears this will likely pull a previous version instead of the most recently published... How should we address this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure. Maybe the index takes more than 3 seconds to update?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if that doesn't help, we can also install manually and check that it works

dcherian added a commit to matzegoebel/xarray that referenced this pull request May 13, 2021
* upstream/master: (23 commits)
  combine keep_attrs and combine_attrs in apply_ufunc (pydata#5041)
  Explained what a deprecation cycle is (pydata#5289)
  Code cleanup (pydata#5234)
  FacetGrid docstrings (pydata#5293)
  Add whats new for dataset interpolation with non-numerics (pydata#5297)
  Allow dataset interpolation with different datatypes (pydata#5008)
  Flexible indexes: add Index base class and xindexes properties (pydata#5102)
  pre-commit: autoupdate hook versions (pydata#5280)
  convert the examples for apply_ufunc to doctest (pydata#5279)
  fix the new whatsnew section
  Ensure `HighLevelGraph` layers are `Layer` instances (pydata#5271)
  New whatsnew section
  Release-workflow: Bug fix (pydata#5273)
  more maintenance on whats-new.rst (pydata#5272)
  v0.18.0 release highlights (pydata#5266)
  Fix exception when display_expand_data=False for file-backed array. (pydata#5235)
  Warn ignored keep attrs (pydata#5265)
  Disable workflows on forks (pydata#5267)
  fix the built wheel test (pydata#5270)
  pypi upload workflow maintenance (pydata#5269)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants