Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump the dependencies #4942

Merged
merged 6 commits into from
Feb 24, 2021
Merged

bump the dependencies #4942

merged 6 commits into from
Feb 24, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Feb 22, 2021 •
edited
Loading

The updated policy (see #4907) allows bumping quite a few dependencies. Not sure if bumping all of them makes sense, but I'd like to see what CI does with this.

  • Passes pre-commit run --all-files
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

@rhkleijn
Copy link
Contributor

If the minimum version of numpy is increased to 1.17 you may want to change the PendingDeprecationWarning in ufuncs.py to DeprecationWarning:

xarray/xarray/ufuncs.py

Lines 47 to 53 in 200c2b2

_warnings.warn(
"xarray.ufuncs will be deprecated when xarray no longer "
"supports versions of numpy older than v1.17. Instead, use "
"numpy ufuncs directly.",
PendingDeprecationWarning,
stacklevel=2,
)

@keewis
Copy link
Collaborator Author

keewis commented Feb 22, 2021 •
edited
Loading

Thanks for the reminder, @rhkleijn. I think we want to discuss that some more in #4116.

This is the full extent of what the new policy would allow us to do. Not sure if we will actually bump to 1.17, or if we decide that deprecating two versions of numpy at once is too much.

andersy005
andersy005 approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

max-sixty
max-sixty approved these changes Feb 22, 2021
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd vote to bump these according to the policy like you have, and if that means multiple versions of numpy, then that's fine.

keewis
keewis commented Feb 23, 2021
View reviewed changes
doc/whats-new.rst Outdated Show resolved Hide resolved
@mathause
Copy link
Collaborator

That might be something to discuss in our meetings?

@max-sixty
Copy link
Collaborator

Shall we merge now and then I'll do the release, so the release notes are updated?

@keewis
Copy link
Collaborator Author

keewis commented Feb 23, 2021 •
edited
Loading

go ahead. I would check the rendered table first, though.

Edit: the table is still pretty big but that's probably fine

@dcherian dcherian requested a review from shoyer February 24, 2021 00:01
@max-sixty
Copy link
Collaborator

OK great, going to merge and then will release shortly!

@max-sixty max-sixty merged commit 63f2e5d into pydata:master Feb 24, 2021
@keewis keewis deleted the bump-dependencies branch February 24, 2021 21:26
@keewis keewis mentioned this pull request Feb 27, 2021
Closed
1 task
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 8, 2021
@dcherian
Merge remote-tracking branch 'upstream/master' into fix/4107
3f04332 
* upstream/master: (46 commits)
  pin netCDF4=1.5.3 in min-all-deps (pydata#4982)
  fix matplotlib errors for single level discrete colormaps (pydata#4256)
  Adapt exception handling in CFTimeIndex.__sub__ and __rsub__ (pydata#5006)
  Update options.py (pydata#5000)
  Adjust tests to use updated pandas syntax for offsets (pydata#4537)
  add a combine_attrs parameter to Dataset.merge (pydata#4895)
  Support for dask.graph_manipulation (pydata#4965)
  raise on passing axis to Dataset.reduce methods (pydata#4940)
  Whatsnew for 0.17.1 (pydata#4963)
  Refinements to how-to-release (pydata#4964)
  DOC: add example for reindex (pydata#4956)
  DOC: rm np import (pydata#4949)
  Add 0.17.0 release notes (pydata#4953)
  document update as inplace (pydata#4932)
  bump the dependencies (pydata#4942)
  Upstream CI: limit runtime (pydata#4946)
  typing for numpy 1.20 (pydata#4878)
  Use definition of DTypeLike from Numpy if found (pydata#4941)
  autoupdate mypy (pydata#4943)
  Add DataArrayCoarsen.reduce and DatasetCoarsen.reduce methods (pydata#4939)
  ...
@nameloCmaS nameloCmaS mentioned this pull request Jan 24, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

@andersy005 andersy005 andersy005 approved these changes

@shoyer shoyer Awaiting requested review from shoyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@keewis @rhkleijn @mathause @max-sixty @andersy005