Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the references to _file_obj outside low level code paths, change to _close #4809

Merged
merged 18 commits into from
Jan 18, 2021
Merged

Remove the references to _file_obj outside low level code paths, change to _close #4809

merged 18 commits into from
Jan 18, 2021

Commits on Jan 14, 2021

  1. Move from _file_obj object to _close function

    @alexamici
    alexamici committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    db0df5d View commit details
    Browse the repository at this point in the history

  2. Remove all references to _close outside of low level

    @alexamici
    alexamici committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    cbb89ff View commit details
    Browse the repository at this point in the history

  3. Fix type hints

    @alexamici
    alexamici committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    fed7d90 View commit details
    Browse the repository at this point in the history

  4. Cleanup code style

    @alexamici
    alexamici committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    b2c8739 View commit details
    Browse the repository at this point in the history

  5. Fix non-trivial type hint problem

    @alexamici
    alexamici committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    8b56025 View commit details
    Browse the repository at this point in the history

  6. Revert adding the close argument and add a set_close instead

    @alexamici
    alexamici committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    4f6b899 View commit details
    Browse the repository at this point in the history

  7. Remove helper class for an easier helper function + code style

    @alexamici
    alexamici committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    eb6e89c View commit details
    Browse the repository at this point in the history

  8. Add set_close docstring

    @alexamici
    alexamici committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    552b652 View commit details
    Browse the repository at this point in the history

  9. Code style

    @alexamici
    alexamici committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    947c3b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Revert changes in _replace to keep cose as an exception 

    See: https://github.com/pydata/xarray/pull/4809/files#r557628298
    @alexamici
    alexamici committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    3a67aca View commit details
    Browse the repository at this point in the history

  2. One more bit to revert

    @alexamici
    alexamici committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    32976b1 View commit details
    Browse the repository at this point in the history

  3. One more bit to revert

    @alexamici
    alexamici committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    82efe0d View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into refactor-dataset-… 

    …close
    @alexamici
    alexamici committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    858af7a View commit details
    Browse the repository at this point in the history

  5. Add What's New entry

    @alexamici
    alexamici committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    675b0fe View commit details
    Browse the repository at this point in the history

  6. Use set_close setter

    @alexamici
    alexamici committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    538371f View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Stephan Hoyer <shoyer@google.com>
    @alexamici @shoyer
    alexamici and shoyer authored Jan 15, 2021
    Configuration menu
    Copy the full SHA
    65e43bf View commit details
    Browse the repository at this point in the history

  8. Rename user-visible argument

    @alexamici
    alexamici committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    a8f96b6 View commit details
    Browse the repository at this point in the history

  9. Sync wording in docstrings.

    @alexamici
    alexamici committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    5f047a6 View commit details
    Browse the repository at this point in the history