Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CI from azure pipelines to GitHub Actions #4730
Migrate CI from azure pipelines to GitHub Actions #4730
Changes from 22 commits
4168a5f
24c7d78
855d6b5
8f9f81b
eb6581d
b37d894
60d08eb
bdd3986
26604a5
6445b47
80da331
32114b2
4eacb65
4c6252b
002ab25
e65c655
06b8334
e70fb89
edf8d14
ec1e5fc
257529b
26a0316
b2287ae
8530374
e6baaa2
3c8da76
28eca4b
b834919
310bc06
646b079
c4b4139
ffcebe2
b2c46db
8437d12
ffe53b9
afaf4b6
1a8ba88
133bb6c
09ee1f6
3c96c19
8760d15
8446ada
5bf36f1
fe10a28
954cc69
86e7dc6
fa5bb1f
3df58b7
c7a91d7
1328110
7c4de89
c60dcd9
5e6ddf2
93ff1ce
3cf7d3e
a6f4d60
fe18db1
f4088f6
c869ee2
11fdc01
5c6c49b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we currently don't use the
-OO
flag in the upstream-dev CI. Should we add it to the upstream-dev CI or remove it here and from CI Additional?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andersy005 - thoughts on this one? Otherwise I think we merge this and follow up with dev doc updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a preference. I used the
-OO
flag because it was present in the previous azure pipelines CI. For consistency, I'm going to remove itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks. If we had a specific reason for
-OO
we can always add it back in a new PR, I guess.