Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger upstream CI on cron schedule (by default) #4729

Merged
merged 40 commits into from
Jan 6, 2021
Merged

Trigger upstream CI on cron schedule (by default) #4729

merged 40 commits into from
Jan 6, 2021

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Dec 23, 2020 •
edited
Loading

As discussed in today's dev meeting, this PR modifies the push and pull_request event triggers by making sure the upstream dev CI is triggered by cron schedule by default.

  • Passes isort . && black . && mypy . && flake8
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

@andersy005 andersy005 added the CI Continuous Integration tools label Dec 23, 2020
@keewis
Copy link
Collaborator

keewis commented Dec 23, 2020 •
edited
Loading

I think there were a few tricks we used to make sure certain steps are only run for the scheduled CI. Should we remove them now, or is it better to wait with that until we decide whether or not to move all most CI to Github Actions?

@andersy005
Copy link
Member Author

I think there were a few tricks we used to make sure certain steps are only run for the scheduled CI. Should we remove them now,

I just removed them (without the other event types, we don't need them anymore). I am going to submit another PR with the migration of the other CI to GitHub actions.

@andersy005 andersy005 changed the title Trigger upstream CI on cron schedule only Trigger upstream CI on cron schedule only (by default) Dec 24, 2020
@andersy005 andersy005 changed the title Trigger upstream CI on cron schedule only (by default) Trigger upstream CI on cron schedule (by default) Dec 24, 2020
keewis
keewis reviewed Dec 28, 2020
View reviewed changes
.github/workflows/upstream-dev-ci.yaml Outdated Show resolved Hide resolved
.github/workflows/upstream-dev-ci.yaml Outdated Show resolved Hide resolved
.github/workflows/upstream-dev-ci.yaml Outdated Show resolved Hide resolved
keewis
keewis reviewed Jan 3, 2021
View reviewed changes
Copy link
Collaborator

@keewis keewis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with my suggestion this works, but it will leave a extra job.

For reference, we somehow have to extract the subject line to make sure the extra build was requested for this commit (squash merges concatenate the commit messages of all commits of a PR into a single commit).

Once github allows accessing only the subject (or adds string manipulation to the expression syntax) we might be able to get rid of this.

.github/workflows/upstream-dev-ci.yaml Show resolved Hide resolved
.github/workflows/upstream-dev-ci.yaml Show resolved Hide resolved
.github/workflows/upstream-dev-ci.yaml Outdated Show resolved Hide resolved
@keewis keewis mentioned this pull request Jan 3, 2021
Merged
6 tasks
@keewis
Copy link
Collaborator

keewis commented Jan 4, 2021

now that it works, we should probably document [test-upstream] somewhere. I think this would fit in the PR template (as a comment?) or the contributing guide.

@keewis keewis mentioned this pull request Jan 5, 2021
Merged
@andersy005 @keewis
Update text about git commit message
dbfecd6 
Co-authored-by: keewis <keewis@users.noreply.github.com>
@keewis
Copy link
Collaborator

keewis commented Jan 6, 2021

@andersy005, I think this is ready. Feel free to merge.

@andersy005
Copy link
Member Author

Thank you for input and feedback @keewis and @dcherian

@andersy005 andersy005 merged commit bc49e27 into pydata:master Jan 6, 2021
@andersy005 andersy005 deleted the ci/trigger-upstream-ci-on-cron-schedule-only branch January 6, 2021 22:17
@keewis keewis mentioned this pull request Jan 12, 2021
Closed
dcherian added a commit to TomNicholas/xarray that referenced this pull request Jan 18, 2021
@dcherian
Merge remote-tracking branch 'upstream/master' into integrate_dim_arg
b9c1e6f 
* upstream/master: (342 commits)
  fix decode for scale/ offset list (pydata#4802)
  Expand user dir paths (~) in open_mfdataset and to_zarr. (pydata#4795)
  add a version info step to the upstream-dev CI (pydata#4815)
  fix the ci trigger action (pydata#4805)
  scatter plot by order of the first appearance of hue (pydata#4723)
  don't skip the scheduled CI (pydata#4806)
  coords: retain str dtype (pydata#4759)
  Fix interval labels with units (pydata#4794)
  Always force dask arrays to float in missing.interp_func (pydata#4771)
  Print number of variables in repr (pydata#4762)
  install conda as a library in the minimum dependency check CI (pydata#4792)
  Migrate CI from azure pipelines to GitHub Actions (pydata#4730)
  use conda.api instead of parallel calls to the conda binary (pydata#4775)
  Speed up missing._get_interpolator (pydata#4776)
  Remove special case in guess_engines (pydata#4777)
  improve typing of OrderedSet (pydata#4774)
  CI: ignore some warnings (pydata#4773)
  DOC: update hyperlink for xskillscore (pydata#4778)
  drop support for python 3.6 (pydata#4720)
  Trigger upstream CI on cron schedule (by default) (pydata#4729)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian left review comments

@keewis keewis keewis approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andersy005 @keewis @dcherian