Fix rolling window operations with dask when bottleneck is installed #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xref GH2940, GH2942 Previously, these operations could silently return incorrect results (dask 2.0), or use unbounded amounts of memory (older versions of dask). This requires a fairly large refactoring, because deciding when to use bottleneck now needs to be done at runtime rather than at import-time. These methods are now constructed as methods rather being injected aftewards into the class, which should also be a much more standard and understable design.
This was referenced Jun 23, 2019
Closed
This was referenced Jun 25, 2019
…array into dask-rolling-disable-bottleneck
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, these operations could silently return incorrect results (dask
2.0), or use unbounded amounts of memory (older versions of dask).
This requires a fairly large refactoring, because deciding when to use
bottleneck now needs to be done at runtime rather than at import-time. These
methods are now constructed as methods rather being injected aftewards into
the class, which should also be a much more standard and understable design.
whats-new.rstfor all changes andapi.rstfor new API