Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors with isnull() that appear with pandas 0.21 #1549

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Fix errors with isnull() that appear with pandas 0.21 #1549

merged 1 commit into from
Sep 5, 2017

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Sep 2, 2017

xref #1542

  • Tests added / passed
  • Passes git diff upstream/master | flake8 --diff
  • Fully documented, including whats-new.rst for all changes and api.rst for new API

@shoyer
Copy link
Member Author

shoyer commented Sep 2, 2017

The culprit is the truly monstrous _func_slash_method_wrapper function where we read names from methods if need be:
https://github.com/pydata/xarray/blob/master/xarray/core/ops.py#L211-L216

We should have a more sane way to add methods on xarray objects, but this fix will have to do for now.

@shoyer shoyer mentioned this pull request Sep 2, 2017
Closed
@shoyer shoyer merged commit 25455b3 into pydata:master Sep 5, 2017
@shoyer shoyer deleted the isnull-isna-patch branch September 5, 2017 06:02
@shoyer shoyer mentioned this pull request Oct 27, 2017
Closed
@jhamman jhamman mentioned this pull request Nov 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoyer @jhamman