Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'signature' argument in apply_ufunc with *_core_dims #1245

Merged
merged 2 commits into from
Feb 7, 2017
Merged

Replace 'signature' argument in apply_ufunc with *_core_dims #1245

merged 2 commits into from
Feb 7, 2017

Commits on Feb 2, 2017

  1. Replace 'signature' argument to apply_func with *_core_dims 

    This results in a much easier to use function signature than the previous
`signature` argument which required triply nested lists.

e.g., new:

    def inner_product(a, b, dim):
        return apply_ufunc(_inner, a, b, input_core_dims=[[dim], [dim]])

vs. old:

    def inner_product(a, b, dim):
        return apply_ufunc(_inner, a, b, signature=[[[dim], [dim]], []])
    @shoyer
    shoyer committed Feb 2, 2017
    Configuration menu
    Copy the full SHA
    6cd91a7 View commit details
    Browse the repository at this point in the history

  2. Remove use of lambdas to please flake8

    @shoyer
    shoyer committed Feb 2, 2017
    Configuration menu
    Copy the full SHA
    def3821 View commit details
    Browse the repository at this point in the history