Skip to content

Commit

Permalink
support chunks in open_groups and open_datatree (#9660)
Browse files Browse the repository at this point in the history
* support chunking and default values in `open_groups`

* same for `open_datatree`

* use `group_subtrees` instead of `map_over_datasets`

* check that `chunks` on `open_datatree` works

* specify the chunksizes when opening from disk

* check that `open_groups` with chunks works, too

* require dask for `test_open_groups_chunks`

* protect variables from write operations

* copy over `_close` from the backend tree

* copy a lot of the docstring from `open_dataset`

* same for `open_groups`

* reuse `_protect_dataset_variables_inplace`

* final missing `requires_dask`

* typing for the test utils

Co-authored-by: Tom Nicholas <tom@cworthy.org>

* type hints for `_protect_datatree_variables_inplace`

Co-authored-by: Tom Nicholas <tom@cworthy.org>

* type hints for `_protect_dataset_variables_inplace`

* copy over the name of the backend tree

Co-authored-by: Tom Nicholas <TomNicholas@users.noreply.github.com>

* typo

* swap the order of arguments to `assert_identical`

* try explicitly typing `data`

* typo

* use `Hashable` for variable names

---------

Co-authored-by: Tom Nicholas <tom@cworthy.org>
Co-authored-by: Tom Nicholas <TomNicholas@users.noreply.github.com>
  • Loading branch information
3 people authored Oct 24, 2024
1 parent b133fdc commit 521b087
Show file tree
Hide file tree
Showing 2 changed files with 602 additions and 16 deletions.
Loading

0 comments on commit 521b087

Please sign in to comment.