Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Enable finch backend for scipy.sparse #664

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Apr 15, 2024

Hi @hameerabbasi,

Once finch-tensor/finch-tensor-python#31 is merged this PR will make sure that scipy.sparse also accepts finch-backend tensors!

@mtsokol mtsokol self-assigned this Apr 15, 2024
Copy link

github-actions bot commented Apr 15, 2024

Test Results

5 923 tests  +10   5 891 ✅ +12   7m 1s ⏱️ - 1m 56s
    1 suites ± 0      32 💤  -  2 
    1 files   ± 0       0 ❌ ± 0 

Results for commit 017cb7d. ± Comparison against base commit 5bd2df6.

This pull request removes 6 and adds 16 tests. Note that renamed tests count towards both.
sparse.tests.test_backends ‑ test_asarray[BackendType.Finch-coo]
sparse.tests.test_backends ‑ test_asarray[BackendType.Finch-csc]
sparse.tests.test_backends ‑ test_asarray[BackendType.Finch-csr]
sparse.tests.test_backends ‑ test_asarray[BackendType.PyData-coo]
sparse.tests.test_backends ‑ test_asarray[BackendType.PyData-csc]
sparse.tests.test_backends ‑ test_asarray[BackendType.PyData-csr]
sparse.tests.test_backends ‑ test_asarray[BackendType.Finch-coo-C]
sparse.tests.test_backends ‑ test_asarray[BackendType.Finch-coo-F]
sparse.tests.test_backends ‑ test_asarray[BackendType.Finch-csc-F]
sparse.tests.test_backends ‑ test_asarray[BackendType.Finch-csr-C]
sparse.tests.test_backends ‑ test_asarray[BackendType.PyData-coo-C]
sparse.tests.test_backends ‑ test_asarray[BackendType.PyData-coo-F]
sparse.tests.test_backends ‑ test_asarray[BackendType.PyData-csc-F]
sparse.tests.test_backends ‑ test_asarray[BackendType.PyData-csr-C]
sparse.tests.test_backends ‑ test_scipy_sparse_dispatch[BackendType.Finch-coo-C]
sparse.tests.test_backends ‑ test_scipy_sparse_dispatch[BackendType.Finch-coo-F]
…

♻️ This comment has been updated with latest results.

@mtsokol mtsokol force-pushed the scipy-finch-backend branch from 6823373 to aba26bd Compare April 16, 2024 11:17
sparse/tests/test_backends.py Outdated Show resolved Hide resolved
Co-authored-by: Hameer Abbasi <2190658+hameerabbasi@users.noreply.github.com>
@mtsokol mtsokol force-pushed the scipy-finch-backend branch from 1949586 to 017cb7d Compare April 16, 2024 11:58
@mtsokol mtsokol requested a review from hameerabbasi April 16, 2024 12:11
@hameerabbasi hameerabbasi merged commit 705699f into main Apr 16, 2024
10 checks passed
@hameerabbasi hameerabbasi deleted the scipy-finch-backend branch April 16, 2024 12:18
@mtsokol
Copy link
Collaborator Author

mtsokol commented Apr 16, 2024

@hameerabbasi Thank you for reviewing! Could you also cut a new alpha release?

@hameerabbasi
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants