Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Update asarray function #658

Merged
merged 1 commit into from
Mar 29, 2024
Merged

API: Update asarray function #658

merged 1 commit into from
Mar 29, 2024

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Mar 28, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2024 •
edited
Loading

Test Results

5 905 tests  +6   5 874 ✅ +7   6m 22s ⏱️ - 1m 32s
    1 suites ±0      31 💤  - 1 
    1 files   ±0       0 ❌ ±0 

Results for commit 63a8593. ± Comparison against base commit f95eeb3.

This pull request skips 1 and un-skips 2 tests. 
sparse.pydata_backend.tests.test_coo ‑ test_reductions_float16[i4-None-sum-kwargs0]

sparse.pydata_backend.tests.test_compressed ‑ test_reductions_float16[i8-None-sum-kwargs0]
sparse.pydata_backend.tests.test_coo ‑ test_reductions_float16[f4-None-sum-kwargs0]

♻️ This comment has been updated with latest results.

@mtsokol mtsokol self-assigned this Mar 29, 2024
@mtsokol mtsokol marked this pull request as ready for review March 29, 2024 10:25
@mtsokol mtsokol requested a review from hameerabbasi March 29, 2024 10:39
hameerabbasi
hameerabbasi requested changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes.

sparse/pydata_backend/_compressed/compressed.py Outdated Show resolved Hide resolved
sparse/pydata_backend/_compressed/compressed.py Outdated Show resolved Hide resolved
@mtsokol mtsokol merged commit 9a8b31a into main Mar 29, 2024
10 checks passed
@mtsokol mtsokol deleted the asarray-update branch March 29, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hameerabbasi hameerabbasi hameerabbasi approved these changes

Assignees

@mtsokol mtsokol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtsokol @hameerabbasi