Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SciPy a soft dependency #632

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Conversation

hameerabbasi
Copy link
Collaborator

Fixes #631
Fixes #626

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Merging #632 (156c47f) into main (16b46cd) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
+ Coverage   90.20%   90.22%   +0.02%     
==========================================
  Files          20       20              
  Lines        3654     3663       +9     
==========================================
+ Hits         3296     3305       +9     
  Misses        358      358              

sparse/_dok.py Dismissed Show dismissed Hide dismissed
sparse/_umath.py Dismissed Show dismissed Hide dismissed
sparse/_coo/common.py Dismissed Show dismissed Hide dismissed
sparse/_coo/common.py Dismissed Show dismissed Hide dismissed
sparse/_coo/common.py Dismissed Show dismissed Hide dismissed
sparse/_coo/common.py Fixed Show fixed Hide fixed
sparse/_coo/common.py Fixed Show fixed Hide fixed
sparse/_coo/common.py Fixed Show fixed Hide fixed
sparse/_coo/common.py Fixed Show fixed Hide fixed
sparse/_coo/core.py Dismissed Show dismissed Hide dismissed
@hameerabbasi hameerabbasi requested a review from mtsokol January 16, 2024 17:37
@hameerabbasi hameerabbasi changed the title Soft scipy dep Make SciPy a soft dependency Jan 16, 2024
@hameerabbasi hameerabbasi enabled auto-merge (squash) January 16, 2024 17:40
@hameerabbasi hameerabbasi merged commit c57fed2 into pydata:main Jan 16, 2024
13 checks passed
hameerabbasi added a commit to hameerabbasi/sparse that referenced this pull request Jan 18, 2024
* Make SciPy a soft dependency.

* Fix packaging issue.

* Add scipy to doc deps.

* Add docs + __class__ -> __module__.
@hameerabbasi hameerabbasi deleted the soft-scipy-dep branch June 6, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove runtime dependency on SciPy [conda] Sparse version string is not recognized by pip list/check
2 participants