-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SciPy a soft dependency #632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
==========================================
+ Coverage 90.20% 90.22% +0.02%
==========================================
Files 20 20
Lines 3654 3663 +9
==========================================
+ Hits 3296 3305 +9
Misses 358 358 |
hameerabbasi
force-pushed
the
soft-scipy-dep
branch
from
January 16, 2024 18:00
5f5c993
to
156c47f
Compare
mtsokol
approved these changes
Jan 16, 2024
hameerabbasi
added a commit
to hameerabbasi/sparse
that referenced
this pull request
Jan 18, 2024
* Make SciPy a soft dependency. * Fix packaging issue. * Add scipy to doc deps. * Add docs + __class__ -> __module__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #631
Fixes #626