-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more lints to Ruff for better code quality. #621
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #621 +/- ##
==========================================
+ Coverage 90.36% 90.48% +0.11%
==========================================
Files 20 20
Lines 3603 3573 -30
==========================================
- Hits 3256 3233 -23
+ Misses 347 340 -7 |
@mtsokol Do you primarily work on Windows? If so, would it be possible for you to look into why this fails only on Windows? |
I only have macos machine unfortunately. |
@hameerabbasi I have and idea what might be causing the failure. In While working on NEP 52 there was even a discussion to remove Maybe a solution would be to replace |
That worked, thanks! I see you self-requested a review, I'll wait for that before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR also adds lints that check for NumPy 2.0 compatibility.