Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #589
Hi @hameerabbasi,
I think the original error was caused due to the fact that
np.einsum
has kwargs which is missing insparse.einsum
. There is no Array API standard definition foreinsum
function so maybe we can just add**kwargs
tosparse.einsum
to make it compatible.If there are plans for refactoring
sparse.einsum
in the future, then there will be an opportunity to introducedtype
parameter.