Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pre-commit. #617

Merged
merged 11 commits into from
Jan 4, 2024
Merged

Introduce pre-commit. #617

merged 11 commits into from
Jan 4, 2024

Conversation

hameerabbasi
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Merging #617 (fc0fef8) into master (6fca42b) will decrease coverage by 0.20%.
The diff coverage is 85.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
- Coverage   90.62%   90.42%   -0.20%     
==========================================
  Files          20       20              
  Lines        3561     3560       -1     
==========================================
- Hits         3227     3219       -8     
- Misses        334      341       +7     

sparse/_common.py Fixed Show fixed Hide fixed
sparse/_dok.py Dismissed Show dismissed Hide dismissed
sparse/_sparse_array.py Dismissed Show dismissed Hide dismissed
sparse/_umath.py Dismissed Show dismissed Hide dismissed
sparse/_umath.py Dismissed Show dismissed Hide dismissed
sparse/_coo/common.py Dismissed Show dismissed Hide dismissed
sparse/_coo/core.py Dismissed Show dismissed Hide dismissed
sparse/tests/test_elemwise.py Dismissed Show dismissed Hide dismissed
sparse/_coo/common.py Dismissed Show dismissed Hide dismissed
sparse/_common.py Fixed Show fixed Hide fixed
@hameerabbasi hameerabbasi requested a review from mtsokol January 4, 2024 14:14
@hameerabbasi
Copy link
Collaborator Author

hameerabbasi commented Jan 4, 2024

@mtsokol can we make sure that we aren't reducing the Array API coverage here? For example, I noticed any, all, min, max, sum, prod weren't tested before. Just making sure there aren't any others.

Pretty sure the docs build caught everything.

sparse/tests/test_elemwise.py Dismissed Show dismissed Hide dismissed
sparse/_common.py Dismissed Show dismissed Hide dismissed
sparse/_coo/core.py Dismissed Show dismissed Hide dismissed
sparse/_coo/core.py Dismissed Show dismissed Hide dismissed
sparse/_coo/core.py Dismissed Show dismissed Hide dismissed
@hameerabbasi hameerabbasi self-assigned this Jan 4, 2024
@hameerabbasi hameerabbasi removed the request for review from mtsokol January 4, 2024 14:49
@hameerabbasi hameerabbasi merged commit e1990b2 into pydata:master Jan 4, 2024
13 checks passed
@hameerabbasi hameerabbasi deleted the pre-commit branch January 4, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant