change parsing of the input in einsum #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hameerabbasi
requested changes
Feb 24, 2023
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
==========================================
- Coverage 92.19% 92.16% -0.04%
==========================================
Files 20 20
Lines 3204 3304 +100
==========================================
+ Hits 2954 3045 +91
- Misses 250 259 +9 |
|
Seems like a formatting fail -- Perhaps update Also, there are a lot of lines missing from coverage, more comprehensive tests would be appreciated. |
|
Ok, I will add more tests |
hameerabbasi
approved these changes
Feb 27, 2023
|
Thanks, @HadrienNU for the improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing the implemented einsum (many thanks for implementing), it turns out that the ellipsis were not working (and they are used by xarray dot function, my primary motivation for making this work). So in this commit there is an added function _parse_einsum input that is borrowed from numpy with the only change that operand are not cast to numpy array but are left untouched.