-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add benchmarks #419
add benchmarks #419
Conversation
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
==========================================
+ Coverage 95.06% 95.24% +0.17%
==========================================
Files 19 19
Lines 2819 2818 -1
==========================================
+ Hits 2680 2684 +4
+ Misses 139 134 -5 |
@hameerabbasi, does this look okay to you? |
Thanks. Could you run the benchmarks and post a reference? If that works, I'll merge tomorrow. cc @daletovar |
Hey @hameerabbasi, sorry I missed this. Should I just post the results here in the thread? |
@daletovar Yes. Probably my fault, forgot to tag you, but it isn't commonplace on the author's PR. |
|
Here I've added asv benchmarks for GCXS. I also made a couple of changes to COO.