Added multi-axis advanced indexing support

[mikeymezher]

Added support for multi-axis advanced indexing. Speed is comparable to single axis advanced indexing.

[hameerabbasi]

Thanks! This is missing some tests, those are pretty much essential.

[mikeymezher]

It seems like the only failed test is test_slicing_errors(index).
Seems like an issue with the tests. This is likely because an IndexError is no longer being raised if len(adv_idx) is greater than 1 in _coo.indexing.py

What's the protocol for modifying the test cases?

Would you be able to handle this?

[hameerabbasi]

Seems like an issue with the tests. This is likely because an IndexError is no longer being raised if len(adv_idx) is greater than 1 in _coo.indexing.py

That's because the test was "testing" if we didn't have advanced indexing at all. You can get rid of the bad tests.

[hameerabbasi]

What's the protocol for modifying the test cases?

The contributor usually adds tests, and the maintainer/reviewer reviews the code and tests.

[mikeymezher]

Alright, I'll add a few test cases to test_slicing(index) + remove test_slicing_error and submit a new PR

[hameerabbasi]

Oh, you can just push to your branch and it'll modify this PR. Don't need to close at all.

[mikeymezher]

Bug found in returned coordinates. Will attempt to fix tomorrow

[hameerabbasi]

I think you need to add back the tests. It seems the previous tests only had 1D advanced indexing... That's okay, but we need a reasonable error message for not 1D that checks for an error.

[hameerabbasi]

The rest of the failures can be fixed by running pip install black and then black ..

[codecov]

Codecov Report

Merging #343 into master will decrease coverage by 0.04%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   94.11%   94.07%   -0.05%     
==========================================
  Files          19       19              
  Lines        2379     2395      +16     
==========================================
+ Hits         2239     2253      +14     
- Misses        140      142       +2     

[hameerabbasi]

Thanks, @mikeymezher!