Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add _repr_html_ #283

Merged
merged 40 commits into from
Sep 18, 2019
Merged

add _repr_html_ #283

merged 40 commits into from
Sep 18, 2019

Conversation

daletovar
Copy link
Contributor

  • changes 'gxcs' to 'gcxs'
  • adds repr_html for sparse arrays

I just saw the dask PR about this and I got inspired. I modeled it pretty closely after what zarr does.

coo_repr_html

@codecov
Copy link

codecov bot commented Sep 1, 2019

Codecov Report

Merging #283 into master will decrease coverage by 1.66%.
The diff coverage is 32.14%.

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage    94.8%   93.13%   -1.67%     
==========================================
  Files          15       15              
  Lines        1982     2026      +44     
==========================================
+ Hits         1879     1887       +8     
- Misses        103      139      +36

@codecov
Copy link

codecov bot commented Sep 1, 2019

Codecov Report

Merging #283 into master will decrease coverage by 1.48%.
The diff coverage is 32.07%.

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage   94.75%   93.27%   -1.49%     
==========================================
  Files          15       15              
  Lines        2001     2036      +35     
==========================================
+ Hits         1896     1899       +3     
- Misses        105      137      +32

@hameerabbasi
Copy link
Collaborator

@daletovar You'll need to rebase this branch on top of master and pick out only the parts you want.

Also, it would be nice if format was an abstract class property.

"No. Bytes" should be replaced by "size".

"Size if dense" should be removed.

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments.

sparse/_compressed/compressed.py Outdated Show resolved Hide resolved
sparse/_utils.py Outdated Show resolved Hide resolved
sparse/tests/test_compressed.py Show resolved Hide resolved
sparse/_utils.py Outdated Show resolved Hide resolved
@hameerabbasi
Copy link
Collaborator

This pull request introduces 1 alert when merging 77eabe5 into 2eda2dc - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

Warning - Automated code review for pydata/sparse will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@daletovar
Copy link
Contributor Author

Thanks for the review, @hameerabbasi. Next chance I get I'll rebase.

@hameerabbasi
Copy link
Collaborator

This pull request introduces 1 alert when merging 33df589 into 2eda2dc - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

Warning - Automated code review for pydata/sparse will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

sparse/_dok.py Outdated
"""
return "dok"

@property
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be highly inaccurate, I suggest you remove it, since it's a Python dict and not a NumPy one.

@hameerabbasi
Copy link
Collaborator

This pull request introduces 1 alert when merging 5f9d3ef into 161650b - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

Warning - Automated code review for pydata/sparse will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@hameerabbasi hameerabbasi merged commit 96fd044 into pydata:master Sep 18, 2019
@hameerabbasi
Copy link
Collaborator

This pull request introduces 1 alert when merging 5c3fc1a into 161650b - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

Warning - Automated code review for pydata/sparse will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants