-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add _repr_html_ #283
add _repr_html_ #283
Conversation
Update core.py
Raises an error for negative dimensions.
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
- Coverage 94.8% 93.13% -1.67%
==========================================
Files 15 15
Lines 1982 2026 +44
==========================================
+ Hits 1879 1887 +8
- Misses 103 139 +36 |
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
- Coverage 94.75% 93.27% -1.49%
==========================================
Files 15 15
Lines 2001 2036 +35
==========================================
+ Hits 1896 1899 +3
- Misses 105 137 +32 |
@daletovar You'll need to rebase this branch on top of Also, it would be nice if "No. Bytes" should be replaced by "size". "Size if dense" should be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small comments.
Co-Authored-By: Hameer Abbasi <einstein.edison@gmail.com>
This pull request introduces 1 alert when merging 77eabe5 into 2eda2dc - view on LGTM.com new alerts:
Warning - Automated code review for pydata/sparse will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
Thanks for the review, @hameerabbasi. Next chance I get I'll rebase. |
This pull request introduces 1 alert when merging 33df589 into 2eda2dc - view on LGTM.com new alerts:
Warning - Automated code review for pydata/sparse will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
sparse/_dok.py
Outdated
""" | ||
return "dok" | ||
|
||
@property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be highly inaccurate, I suggest you remove it, since it's a Python dict and not a NumPy one.
This pull request introduces 1 alert when merging 5f9d3ef into 161650b - view on LGTM.com new alerts:
Warning - Automated code review for pydata/sparse will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
This pull request introduces 1 alert when merging 5c3fc1a into 161650b - view on LGTM.com new alerts:
Warning - Automated code review for pydata/sparse will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
I just saw the dask PR about this and I got inspired. I modeled it pretty closely after what zarr does.