Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant import. #273

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Remove redundant import. #273

merged 1 commit into from
Aug 12, 2019

Conversation

hameerabbasi
Copy link
Collaborator

@hameerabbasi hameerabbasi commented Aug 12, 2019

Fixes #268

@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #273 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   94.86%   94.86%   -0.01%     
==========================================
  Files          14       14              
  Lines        1948     1947       -1     
==========================================
- Hits         1848     1847       -1     
  Misses        100      100

@hameerabbasi hameerabbasi merged commit 055c411 into master Aug 12, 2019
@crusaderky
Copy link
Contributor

The import was necessary to apply np.result_type to a COO.
Import reinstated and unit test added in #272.

crusaderky added a commit to crusaderky/sparse that referenced this pull request Aug 12, 2019
hameerabbasi pushed a commit that referenced this pull request Aug 12, 2019
* Support numpy 1.17; overhaul tests for __array_function__

* Remove test for matmul (it's a __array_ufunc__)
Don't test stack() with mixed inputs
Mark failures for where()

* xfail reason

* Revert #273

* NEP18 test from dask#4675

* Remove xfail

* result_type implementation; new module sparse.settings
@hameerabbasi hameerabbasi deleted the np-115-fix branch August 14, 2019 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sparse fails to import with NumPy 1.15 installed
2 participants