Clarify error messages #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 97.61% 97.61%
=======================================
Files 11 11
Lines 1549 1549
=======================================
Hits 1512 1512
Misses 37 37
Continue to review full report at Codecov.
|
asmeurer
reviewed
Feb 21, 2019
| raise ValueError('Inconsistent fill-values in the result array: operating on the ndarray with' | ||
| ' fill-values produces inconsistent results.') | ||
| raise ValueError('Performing a mixed sparse-dense operation that would result in a dense array. ' | ||
| 'Please make sure that func(sparse_fill_values, ndarrays) is a constant array.') |
There was a problem hiding this comment.
The element-wise function one wants to apply.
asmeurer
reviewed
Feb 21, 2019
| @@ -507,8 +507,8 @@ def _check_broadcast(self): | |||
| ) | |||
|
|
|||
| if full_shape != non_ndarray_shape: | |||
| raise ValueError('All ndarrays must be broadcastable to the shape without ndarrays {}' | |||
| .format(non_ndarray_shape)) | |||
| raise ValueError('Please make sure that the broadcast shape of just the sparse arrays is ' | |||
There was a problem hiding this comment.
So in the case of a binary operation between dense and sparse as in the issue, "just the sparse arrays" is the one array, so broadcasting the sparse array is not allowed?
|
@asmeurer Do you think these error messages are fine or do they need refining? Feel free to suggest other (clearer) wordings. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231
Fixes #230
@asmeurer Please make sure that these error messages are clear to you... I'm used to speaking deep NumPy-speak, and so I may be a bit blinded. 🙂