Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hover striping from all but .dataframe tables #2059

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Remove hover striping from all but .dataframe tables #2059

merged 3 commits into from
Dec 2, 2024

Conversation

gabalafou
Copy link
Collaborator

Fixes #1894.

@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@gabalafou
Copy link
Collaborator Author

gabalafou commented Nov 28, 2024 •
edited
Loading

To test this, compare the tables at the following URLs.

These should not have a purple background on hover:

Whereas these should have a purple background on hover:

@gabalafou gabalafou mentioned this pull request Nov 30, 2024
Merged
@trallard trallard added tag: accessibility Issues related to accessibility issues or efforts tag: UX Issues or improvements related to user experience labels Dec 2, 2024
@trallard trallard merged commit 8579fb6 into pydata:main Dec 2, 2024
25 checks passed
drammock pushed a commit that referenced this pull request Dec 3, 2024
@gabalafou
Higher contrast table hover stripe (light mode) (#2062)
6cc8ddf 
This pull request:

- changes the background hover color on tables to improve legibility
- differs from the [design
system](https://www.figma.com/design/SnLFWtSKEBLYrtLHbs4TSE/PyData-Sphinx-Theme-Design-System-(Community)?node-id=3312-493),
but I think it looks better, plus it steps up the hover
background/foreground contrast in light mode to meet WCAG AAA.

Note: once #2059 is merged, this will only affect `.dataframe` classes 

### After screenshot


![](https://github.com/user-attachments/assets/75c5049f-db2a-41eb-b327-e186320d7eb5)

![](https://github.com/user-attachments/assets/75434c18-1928-4c6d-96bc-97135e865e1d)


### Before screenshot


![](https://github.com/user-attachments/assets/603b6bae-7e30-48b4-a5a8-51fbf4e29859)

![](https://github.com/user-attachments/assets/c49c3f62-c1e3-475e-8049-cd96b87212c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trallard trallard trallard approved these changes

Assignees
No one assigned
Labels
tag: accessibility Issues related to accessibility issues or efforts tag: UX Issues or improvements related to user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected hover highlight on attributes from auto summary
2 participants
@gabalafou @trallard