change color when hovering over code-formatted text #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
trallard
reviewed
Oct 15, 2024
Comment on lines
+113
to
+115
| def test_colors(sphinx_build_factory: Callable, page: Page, url_base: str) -> None: | ||
| """Test that things get colored the way we expect them to. | ||
|
|
There was a problem hiding this comment.
These seem to be the "light theme" colours; should we be testing for both light and dark?
My gut tells me yes WDYT @drammock @gabalafou ?
There was a problem hiding this comment.
I think that as long as we know that mode switching works, tests like this one (i.e. "did the CSS selector do what we intended" tests) only need to test one mode.
The exception would be any a11y test that checks for color contrast --- obv. we should run that test in both modes.
There was a problem hiding this comment.
We are running those a11y tests on both modes so then we should be covered
trallard
added
kind: bug
trallard
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to assume that #2006 was in fact a bug, so here's a fix. If it's not a bug, we can easily alter this PR to keep the test and discard the CSS change.
also includes a small tweak to the existing "breadcrumbs-everywhere" test:
putting much less in thebeing more explicit about what we expect to sometimes fail, by moving some code out of thetryblock so that it might actually fail in cases where we would want it to fail.tryblock and into anelseblockcloses #2006