fix: remove Site navigation header (#1615)

* fix: remove Site navigation header * test: edit the test suit
pydata · Jan 4, 2024 · e0b39b8 · e0b39b8
1 parent 4aa82e2
commit e0b39b8
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 22 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/pydata_sphinx_theme/assets/styles/components/_navbar-links.scss b/src/pydata_sphinx_theme/assets/styles/components/_navbar-links.scss
@@ -53,8 +53,3 @@
     }
   }
 }
-
-// Don't display the `site navigation` in the header menu
-.bd-header .navbar-nav > p.sidebar-header-items__title {
-  display: none;
-}
diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/navbar-nav.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/navbar-nav.html
@@ -1,11 +1,5 @@
 {# Displays links to the top-level TOCtree elements, in the header navbar. #}
 <nav class="navbar-nav">
-  <p class="sidebar-header-items__title"
-     role="heading"
-     aria-level="1"
-     aria-label="{{ _('Site Navigation') }}">
-    {{ _("Site Navigation") }}
-  </p>
   <ul class="bd-navbar-elements navbar-nav">
     {{ generate_header_nav_html(n_links_before_dropdown=theme_header_links_before_dropdown, dropdown_text=theme_header_dropdown_text) }}
   </ul>

diff --git a/tests/test_build.py b/tests/test_build.py
@@ -964,7 +964,6 @@ def test_translations(sphinx_build_factory) -> None:
     index = sphinx_build.html_tree("section1/index.html")
 
     sidebar_primary = index.select(".bd-sidebar-primary")[0]
-    assert "Navigation du site" in str(sidebar_primary)
     assert "Navigation de la section" in str(sidebar_primary)
 
     sidebar_secondary = index.select(".bd-sidebar-secondary")[0]

diff --git a/tests/test_build/navbar_ix.html b/tests/test_build/navbar_ix.html
@@ -1,9 +1,6 @@
 <div class="me-auto navbar-header-items__center">
  <div class="navbar-item">
   <nav class="navbar-nav">
-   <p aria-label="Site Navigation" aria-level="1" class="sidebar-header-items__title" role="heading">
-    Site Navigation
-   </p>
    <ul class="bd-navbar-elements navbar-nav">
     <li class="nav-item">
      <a class="nav-link nav-internal" href="page1.html">

diff --git a/tests/test_build/sidebar_subpage.html b/tests/test_build/sidebar_subpage.html
@@ -3,9 +3,6 @@
   <div class="sidebar-header-items__center">
    <div class="navbar-item">
     <nav class="navbar-nav">
-     <p aria-label="Site Navigation" aria-level="1" class="sidebar-header-items__title" role="heading">
-      Site Navigation
-     </p>
      <ul class="bd-navbar-elements navbar-nav">
       <li class="nav-item">
        <a class="nav-link nav-internal" href="../page1.html">