Skip to content

Commit

Permalink
Import Bootstrap after importing our variable overrides (#2066)
Browse files Browse the repository at this point in the history
This PR restores the effects of the variables defined in
[variables/_bootstrap.scss](https://github.com/pydata/pydata-sphinx-theme/blob/main/src/pydata_sphinx_theme/assets/styles/variables/_bootstrap.scss)

This fixes #2022 and
also fixes another issue that I had noticed when clicking links in the
"More" dropdown. Screenshots:

- Fixed: 

![](https://github.com/user-attachments/assets/060fa3fe-2ce8-4311-b127-7821ddbbdadc)
- Broken: 

![](https://github.com/user-attachments/assets/f1de59b9-e6a6-485f-8e83-22a3548de94f)
  • Loading branch information
gabalafou authored Dec 5, 2024
1 parent 6cc8ddf commit 933ce14
Showing 1 changed file with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
// Import all of Bootstrap scss
// IMPORTANT: our Bootstrap variable overrides must be imported before the
// Bootstrap files that reference those variables; otherwise our overrides will
// have no effect.
@import "variables/bootstrap";

// Import all of Bootstrap scss.
@import "~bootstrap/scss/bootstrap";

// Import FontAwesome from _node_modules
Expand All @@ -8,7 +13,6 @@
@import "~@fortawesome/fontawesome-free/scss/brands";

// Variables
@import "variables/bootstrap";
@import "variables/layout";
@import "variables/fonts";
@import "variables/icons";
Expand Down

0 comments on commit 933ce14

Please sign in to comment.