Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure docs tests always run in the right folder #6487

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Ensure docs tests always run in the right folder #6487

merged 1 commit into from
Jul 10, 2023

Conversation

dmontagu
Copy link
Contributor

@dmontagu dmontagu commented Jul 6, 2023

I frequently find myself annoyed because, if I use PyCharm to run the test_docs.py tests, it defaults to running in a different folder than it uses when run via make test, and it causes some tests to fail.

This PR fixes that and ensures no matter what the cwd is when pytest is running, it gets updated properly and the docs examples tests pass.

skip change file check

Selected Reviewer: @lig

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 75d9a2e
Status: ✅  Deploy successful!
Preview URL: https://86a0060e.pydantic-docs2.pages.dev
Branch Preview URL: https://docs-tests.pydantic-docs2.pages.dev

View logs

@dmontagu
Copy link
Contributor Author

dmontagu commented Jul 6, 2023

please review

@dmontagu
Copy link
Contributor Author

dmontagu commented Jul 6, 2023

please review

Copy link
Contributor

@lig lig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@dmontagu dmontagu merged commit 3cf43c6 into main Jul 10, 2023
@dmontagu dmontagu deleted the docs-tests branch July 10, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants