Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: _pydantic_post_init() reassigns __dict__ and removes properties #3093

Merged
merged 2 commits into from
Sep 4, 2021

Conversation

zulrang
Copy link
Contributor

@zulrang zulrang commented Aug 13, 2021

…added to the object, for example in new(), breaking integration with SQLAlchemy and other libraries #3043

Change Summary

Fixes #3043
Fixes #2924

Related issue number

#3043

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

…added to the object, for example in __new__(), breaking integration with SQLAlchemy and other libraries pydantic#3043
@zulrang
Copy link
Contributor Author

zulrang commented Aug 13, 2021

please review

Copy link
Collaborator

@PrettyWood PrettyWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@PrettyWood PrettyWood merged commit 268c3cc into pydantic:master Sep 4, 2021
jpribyl pushed a commit to liquet-ai/pydantic that referenced this pull request Oct 7, 2021
…ydantic#3093)

* Fix: _pydantic_post_init() reassigns __dict__ and removes properties added to the object, for example in __new__(), breaking integration with SQLAlchemy and other libraries pydantic#3043

* Added changes file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment