Considering extra config in dotenv source #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 95.25% 95.37% +0.12%
==========================================
Files 5 5
Lines 295 303 +8
Branches 74 78 +4
==========================================
+ Hits 281 289 +8
Misses 12 12
Partials 2 2
☔ View full report in Codecov by Sentry. |
pydantic_settings/sources.py
Outdated
| # As `extra` config is allowed in dotenv settings source, We have to | ||
| # update data with extra env variabels from dotenv file. | ||
| for k, v in self.env_vars.items(): | ||
| if v is not None and k not in data: |
There was a problem hiding this comment.
Otherwise test_env_file_none fails
|
I've added a commit and changed the logic to handle case insensitive and sub-model |
|
thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11