Fix nested model problem when case_sensitive=False #34
Conversation
pydantic_settings/sources.py
Outdated
| if not field.annotation: | ||
| values[name] = value | ||
| continue |
There was a problem hiding this comment.
are you sure this is necessary? It looks like where this is called field.annotations is always a BaseModel - also the next line assumes field.annotation.model_fields always exists.
There was a problem hiding this comment.
It's here only to make mypy happy
Item "None" of "Optional[Type[Any]]" has no attribute "model_fields"
There was a problem hiding this comment.
ok, please add a comment saying that, and also support the case where field.annotations is not None but is not a BaseModel - e.g. has no .model_fields attribute.
|
@samuelcolvin I've also added a comment to ignore fields with |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 96.00% 95.25% -0.75%
==========================================
Files 5 5
Lines 275 295 +20
Branches 67 74 +7
==========================================
+ Hits 264 281 +17
- Misses 10 12 +2
- Partials 1 2 +1
☔ View full report in Codecov by Sentry. |
|
|
||
| By having the following models: | ||
|
|
||
| class SubSubSub(BaseModel): |
There was a problem hiding this comment.
one comment (doesn't matter much here since I guess we won't add this to the documentation) - if you want code in docsting, please use markdown with code fences so they examples render properly.
Fixes #9