Deprecate read_env_file and move it to DotEnvSettingsSource
#318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WarpedPixel
force-pushed
the
WarpedPixel/issue296
branch
from
3b2d7c3 to
1bc1e99
Compare
|
please review |
hramezani
reviewed
Jun 25, 2024
hramezani
reviewed
Jul 1, 2024
added 4 commits
July 1, 2024 11:36
Fixes pydantic#296 Adds a method _read_env_file to DotEnvSettingsSource that can be easily overridden. This fix keeps a global function so it can continue to be tested, but adds an underscore to the name. The plain read_env_file is marked as deprecated.
Fixes pydantic#296 Added test and moved bulk of dotenv code into DotEnvSettingsSource so future deprecation will be cleaner
Fixes pydantic#296 Addressed CR feedback
WarpedPixel
force-pushed
the
WarpedPixel/issue296
branch
from
b7912c9 to
33f5646
Compare
hramezani
changed the title
read_env_file and move it to DotEnvSettingsSource
hramezani
approved these changes
Jul 2, 2024
|
Thanks @WarpedPixel |
mr-kamran-ali
referenced
this pull request
in robert-koch-institut/mex-common
Aug 8, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pydantic-settings](https://togithub.com/pydantic/pydantic-settings) ([changelog](https://togithub.com/pydantic/pydantic-settings/releases)) | project.dependencies | minor | `==2.3.4` -> `==2.4.0` | --- ### Release Notes <details> <summary>pydantic/pydantic-settings (pydantic-settings)</summary> ### [`v2.4.0`](https://togithub.com/pydantic/pydantic-settings/releases/tag/v2.4.0) [Compare Source](https://togithub.com/pydantic/pydantic-settings/compare/v2.3.4...v2.4.0) #### What's Changed - Fix regex flags accidentally passed as count by [@​musicinmybrain](https://togithub.com/musicinmybrain) in [https://github.com/pydantic/pydantic-settings/pull/328](https://togithub.com/pydantic/pydantic-settings/pull/328) - Deprecate `read_env_file` and move it to `DotEnvSettingsSource` by [@​WarpedPixel](https://togithub.com/WarpedPixel) in [https://github.com/pydantic/pydantic-settings/pull/318](https://togithub.com/pydantic/pydantic-settings/pull/318) - Fix a bug when loading empty yaml file by [@​hramezani](https://togithub.com/hramezani) in [https://github.com/pydantic/pydantic-settings/pull/330](https://togithub.com/pydantic/pydantic-settings/pull/330) - feat: Enable access to the current state in settings sources by [@​VictorColomb](https://togithub.com/VictorColomb) in [https://github.com/pydantic/pydantic-settings/pull/326](https://togithub.com/pydantic/pydantic-settings/pull/326) - Add support for short options. by [@​kschwab](https://togithub.com/kschwab) in [https://github.com/pydantic/pydantic-settings/pull/339](https://togithub.com/pydantic/pydantic-settings/pull/339) - Add Azure Key Vault settings source by [@​AndreuCodina](https://togithub.com/AndreuCodina) in [https://github.com/pydantic/pydantic-settings/pull/272](https://togithub.com/pydantic/pydantic-settings/pull/272) - Add cli_exit_on_error config option by [@​kschwab](https://togithub.com/kschwab) in [https://github.com/pydantic/pydantic-settings/pull/340](https://togithub.com/pydantic/pydantic-settings/pull/340) #### New Contributors - [@​musicinmybrain](https://togithub.com/musicinmybrain) made their first contribution in [https://github.com/pydantic/pydantic-settings/pull/328](https://togithub.com/pydantic/pydantic-settings/pull/328) - [@​WarpedPixel](https://togithub.com/WarpedPixel) made their first contribution in [https://github.com/pydantic/pydantic-settings/pull/318](https://togithub.com/pydantic/pydantic-settings/pull/318) - [@​VictorColomb](https://togithub.com/VictorColomb) made their first contribution in [https://github.com/pydantic/pydantic-settings/pull/326](https://togithub.com/pydantic/pydantic-settings/pull/326) - [@​AndreuCodina](https://togithub.com/AndreuCodina) made their first contribution in [https://github.com/pydantic/pydantic-settings/pull/272](https://togithub.com/pydantic/pydantic-settings/pull/272) **Full Changelog**: pydantic/pydantic-settings@v2.3.4...v2.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjEuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296
Adds a method _read_env_file to DotEnvSettingsSource that can be easily overridden.
This fix keeps a global function so it can continue to be tested, but adds an underscore to the name.
The plain read_env_file is marked as deprecated.
Selected Reviewer: @samuelcolvin