Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize refcounting op in datetime creation #1590

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Followup to #1583.

This changes some try_into_py methods to take self instead of &self, allowing transfer of the Python reference rather than creating a new one.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #1590 will not alter performance

Comparing dh/into-py-tidy (b9598ba) with main (b5c3e14)

Summary

✅ 157 untouched benchmarks

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@sydney-runkle sydney-runkle merged commit b6395cf into main Dec 18, 2024
29 checks passed
@sydney-runkle sydney-runkle deleted the dh/into-py-tidy branch December 18, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants