Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For missing fields, we don't warn on exclude_, so don't warn on exclude #1403

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

sydney-runkle
Copy link
Member

Copy link

codspeed-hq bot commented Aug 13, 2024

CodSpeed Performance Report

Merging #1403 will not alter performance

Comparing no-warn-on-exclude (128795c) with main (39a6b10)

Summary

✅ 155 untouched benchmarks

Copy link
Member

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a test showing the change in behavior and documenting the new expected behavior?

@sydney-runkle sydney-runkle enabled auto-merge (squash) August 13, 2024 18:22
@sydney-runkle sydney-runkle merged commit a072575 into main Aug 13, 2024
28 checks passed
@sydney-runkle sydney-runkle deleted the no-warn-on-exclude branch August 13, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

model_dump issues UserWarning when using nested excludes into a union
2 participants