check items() exists before calling it a mapping
#117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 96.80% 96.67% -0.14%
==========================================
Files 41 41
Lines 3666 3673 +7
Branches 28 28
==========================================
+ Hits 3549 3551 +2
- Misses 117 122 +5
Continue to review full report at Codecov.
|
|
This didn't quite work, we had to make more changes in #115. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyO3/pyo3#2072
previously the
https://github.com/samuelcolvin/pydantic-core/blob/59ed7e071d6bc0b24f88b8e946081178885a1ee7/src/errors/kinds.rs#L64-L65
Error was raised for strings etc., now we correctly use
DictType.This also highlighted problems in how
try_instanceworks which need to be fixed separately, see #109.