Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add builds for 3.13 wheels #145

Merged
merged 4 commits into from
Oct 7, 2024
Merged

add builds for 3.13 wheels #145

merged 4 commits into from
Oct 7, 2024

Conversation

davidhewitt
Copy link
Collaborator

Closes #144

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.94%. Comparing base (4af2c1c) to head (9b27b8b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files          12       12           
  Lines        2042     2042           
  Branches     2042     2042           
=======================================
  Hits         1857     1857           
  Misses        112      112           
  Partials       73       73           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af2c1c...9b27b8b. Read the comment docs.

Copy link

codspeed-hq bot commented Sep 25, 2024

CodSpeed Performance Report

Merging #145 will improve performances by 10.64%

Comparing dh/3.13-wheels (9b27b8b) with main (4af2c1c)

Summary

⚡ 1 improvements
✅ 72 untouched benchmarks

Benchmarks breakdown

Benchmark main dh/3.13-wheels Change
unicode_jiter_iter 8.2 µs 7.4 µs +10.64%

@moodh
Copy link

moodh commented Oct 7, 2024

Hi, we're currently testing py3.13 (rc3) viability in our project and is most likely blocked by this PR through the python sdk from openai.

openai==1.51.0
├── jiter [required: >=0.4.0,<1, installed: 0.5.0]

Do you have any estimations on when this PR will be merged (and a new version published)?
Thanks!

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidhewitt davidhewitt merged commit 01f1756 into main Oct 7, 2024
54 checks passed
@davidhewitt davidhewitt deleted the dh/3.13-wheels branch October 7, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wheels for Python 3.13
3 participants